Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

docs: Update Docker links in Getting Started docs #1122

Merged
merged 2 commits into from
Aug 24, 2023
Merged

docs: Update Docker links in Getting Started docs #1122

merged 2 commits into from
Aug 24, 2023

Conversation

MimmyJau
Copy link
Contributor

Links currently redirect to:
https://docs.docker.com/desktop/get-started/

Archive of Mac Install link:
https://web.archive.org/web/20220328231039/https://docs.docker.com/desktop/mac/

Archive of Windows Install link:
https://web.archive.org/web/20220629164719/https://docs.docker.com/desktop/windows/

I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 13, 2023 •
edited
Loading

Thanks for the pull request, @MimmyJau! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented Jul 18, 2023

Hi @MimmyJau, thank you for this contribution!

We'll get tests enabled for you next.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 18, 2023
@itsjeyd
Copy link

itsjeyd commented Jul 26, 2023

@MimmyJau Looks like most of the tests finished successfully :) Could you please have a look at the ones that failed?

Once the build is green we'll start the process of getting this PR lined up for review.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Jul 26, 2023
@MimmyJau
Copy link
Contributor Author

Thanks @itsjeyd. According to the logs, seems like the error is:

ImportError: cannot import name 'DEV_PKGS' from 'pip._internal.commands.freeze' (/edx/app/venvs/registrar/lib/python3.8/site-packages/pip/_internal/commands/freeze.py)

Could this possibly be resolved by upgrading to pip-tools 7.x.x? It would be aligned with PR #1132 as well as this PR #1906 from the pip-tools library.

It's not completely clear to me how to fix this. But if there's something I can do, happy to make the changes with some guidance.

@itsjeyd
Copy link

itsjeyd commented Aug 1, 2023 •
edited
Loading

@MimmyJau Thanks for checking. It looks like the build on #1132 is failing, too (albeit with a different error). It might still make sense to test your theory by cherry-picking the changes from #1132 to your branch and seeing if that gets rid of the ImportError that you mentioned.

Another thing that might help would be to bring your branch up to date with master (either by rebasing it or merging in the latest changes).

If the problem persists after completing both of these steps, we can start pinging technical reviewers for help.

@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 15, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 22, 2023

@MimmyJau Looks like we're good to go here! The build is :green:

Hi @jmbowman, this PR is ready for review by arch-bom.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 22, 2023
rgraber
rgraber approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgraber rgraber merged commit 18cab2b into openedx-unsupported:master Aug 24, 2023
10 checks passed
@openedx-webhooks
Copy link

@MimmyJau 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@rgraber rgraber removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 24, 2023
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
@MimmyJau @e0d @nsprenkle
docs: Update Docker links in Getting Started docs (#1122)
90e437f 
Links currently redirect to:
https://docs.docker.com/desktop/get-started/

Archive of Mac Install link:
https://web.archive.org/web/20220328231039/https://docs.docker.com/desktop/mac/

Archive of Windows Install link:
https://web.archive.org/web/20220629164719/https://docs.docker.com/desktop/windows/

Co-authored-by: Edward Zarecor <ezarecor@tcril.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rgraber rgraber rgraber approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MimmyJau @openedx-webhooks @itsjeyd @rgraber @e0d